Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Use findbugs annotations (as JSR 305 is dormant) #397

Merged
merged 1 commit into from
Jan 20, 2022
Merged

Use findbugs annotations (as JSR 305 is dormant) #397

merged 1 commit into from
Jan 20, 2022

Conversation

basil
Copy link
Member

@basil basil commented Dec 31, 2021

Adapting to jenkinsci/jenkins#4604.

@rantoniuk
Copy link
Contributor

rantoniuk commented Jan 2, 2022 •
edited
Loading

Personally I prefer not to use tool-specific annotations. How about jakarta-api annotations as discussed here?
I didn't see any discussion in the JENKINS so I'm curious if that has been taken into consideration.

cc @jtnord, @olamy

@basil
Copy link
Member Author

basil commented Jan 2, 2022

@rantoniuk As of jenkinsci/jenkins#4604, core switched from JSR 305 to SpotBugs annotations. As of jenkinsci/plugin-pom#467 the plugin parent POM no longer delivers JSR 305.

@basil basil mentioned this pull request Jan 2, 2022
Closed
@rantoniuk rantoniuk requested a review from olamy January 5, 2022 11:18
@olamy olamy added the dependencies Release Drafter label label Jan 20, 2022
@olamy olamy changed the title EOL JSR 305 Use findbugs annotations (as JSR 305 is dormant) Jan 20, 2022
@olamy olamy merged commit 0f2ce59 into jenkinsci:master Jan 20, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@rantoniuk rantoniuk rantoniuk approved these changes

@olamy olamy Awaiting requested review from olamy

Assignees
No one assigned
Labels
dependencies Release Drafter label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@basil @rantoniuk @olamy