Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Ability to overwrite hard-coded success status check description #674

Closed
justusbunsi opened this issue Feb 17, 2025 · 2 comments · Fixed by #675
Closed

Ability to overwrite hard-coded success status check description #674

justusbunsi opened this issue Feb 17, 2025 · 2 comments · Fixed by #675

Comments

@justusbunsi
Copy link
Member

justusbunsi commented Feb 17, 2025

What feature do you want to see added?

Hi every, I recently added "Gitea Checks" plugin to my Jenkins instance, leading to junit(...) build steps now automatically sending a status check to the built SCM commit. When all tests succeed, there is a hard-coded status check description, pointing to the issues page of this repository. Is there any way to change this in the current codebase?

ChecksOutput output = new ChecksOutput.ChecksOutputBuilder()
.withTitle(extractChecksTitle())
.withSummary("<sub>Send us [feedback](https://github.com/jenkinsci/junit-plugin/issues)")
.withText(extractChecksText(testsURL))
.build();

Upstream changes

No response

Are you interested in contributing this feature?

I'll try my best to provide such PR, depending on your decision how to implement. Would you accept a PR, changing it to "No tests failed" or making it configurable?

@timja
Copy link
Member

timja commented Feb 17, 2025

Yeah find to change it to something like No tests failed etc. Don't think we've ever gotten feedback from it.

Configurable is fine too but might be a bit complex

@justusbunsi
Copy link
Member Author

I just noticed that the description also appears when tests fail. Not sure if it's specific to using "Gitea checks". Will investigate this together with this change here.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants