Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Reuse title information as summary #675

Merged
merged 4 commits into from
Feb 18, 2025
Merged

Conversation

justusbunsi
Copy link
Member

These changes remove the hard-coded summary that links to the repository issue page.
I had a peak on how the xunit plugin provides such status check details.
They split test result details from overall summary.

Unfortunately, github-checks-plugin and gitea-checks-plugin seem to use different parts of the provided status check information. That's why every test report on any Jenkins plugin already has the passed: xyz as status check details.
Gitea seems to receive the static repo issue "fallback" instead.
So, splitting the currently provided information like xunit does it would probably be a somewhat breaking change.
That's why I simply reused the text provided as "Title".

Resolves #674

Testing done

  • Unit test execution via mvn clean verify
  • Plugin usage in Jenkins, screenshots below for different behaviors

Single failing test:
image

Multiple failing tests:
image

All passing tests:
image

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@justusbunsi justusbunsi requested a review from a team as a code owner February 18, 2025 13:32
@justusbunsi
Copy link
Member Author

@timja Text is now calculated once.

@timja timja enabled auto-merge (squash) February 18, 2025 16:44
@timja timja merged commit 13ec14a into jenkinsci:master Feb 18, 2025
17 checks passed
@justusbunsi justusbunsi deleted the issue-674 branch February 18, 2025 17:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to overwrite hard-coded success status check description
2 participants