Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

rawEncoding getSafeName within getRelativePathFrom in TestObject.java #668

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

ahadalioglu
Copy link
Contributor

@ahadalioglu ahadalioglu commented Dec 17, 2024

Fixes #662

Testing was conducted on Jenkins v2.479.2, and it has been confirmed that the links within All Failed Tests now work correctly, even with brackets in the URLs.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@ahadalioglu ahadalioglu requested a review from a team as a code owner December 17, 2024 15:36
@ahadalioglu
Copy link
Contributor Author

@basil I have followed your comment and created another branch & PR with recommended change here...

Now, trying to see if I can test it locally...

@ahadalioglu
Copy link
Contributor Author

ahadalioglu commented Dec 19, 2024

@basil I tested it on our active Jenkins server (version 2.479.2) and confirmed that the links in "All Failed Tests" now function correctly, even with brackets in the URLs - FYI

Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@basil basil added the bug label Dec 19, 2024
@basil basil merged commit 1a235ab into jenkinsci:master Dec 19, 2024
17 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URL encoding issue in "All Failed Tests" links with square brackets
2 participants