Fix failing tests due to Command Palette change #50
Conversation
| @@ -3,14 +3,14 @@ | |||
| <parent> | |||
| <groupId>org.jenkins-ci.plugins</groupId> | |||
| <artifactId>plugin</artifactId> | |||
| <version>5.2</version> | |||
| <version>5.5</version> | |||
There was a problem hiding this comment.
Getting spammed with CSS errors on newer versions of Jenkins unless we up the version of CSSParser used
There was a problem hiding this comment.
This looks good too. What kind of warnings you get?
| <relativePath /> | ||
| </parent> | ||
| <properties> | ||
| <revision>1.37</revision> | ||
| <changelist>-SNAPSHOT</changelist> | ||
| <jenkins.baseline>2.479</jenkins.baseline> | ||
| <jenkins.version>${jenkins.baseline}.1</jenkins.version> | ||
| <jenkins.version>2.494</jenkins.version> |
|
First of all I think command palete and search are two different things, and should have never be merged, but to late for that:( |
| NestedViewTest.searchAndCheck1(wc, rule); | ||
| NestedViewTest.searchAndCheck2(wc, rule); | ||
| NestedViewTest.searchAndCheck3(wc, rule); | ||
| NestedViewTest.searchAndCheck4(wc, rule); |
There was a problem hiding this comment.
Well, this is literally making the test to test nothing. Yes they were failing, becasue I'm pretty sure the nested view test extension is not working with new palette.
| // } catch (NullPointerException exx) { | ||
| // ex = exx; | ||
| // } | ||
| // assertNotNull(ex); | ||
| } |
There was a problem hiding this comment.
This was testing, tat the search is not used, if it is disabled in mains ettings
There was a problem hiding this comment.
Heya. Trying the master branch and the search item appears in this test, it's just that the HREF on the page is relative rather than absolute, thus the test is passing. I'm a little confused.
There was a problem hiding this comment.
I think the absolute url was necessary because of nested-view complex path. But still yours approach should be ok. Sorry. I still did not have cycle to double check that
| @@ -136,7 +136,7 @@ public SearchResult getSuggestions(final StaplerRequest2 req, @QueryParameter fi | |||
| if (this.query.isNonTrivial(true)) { | |||
| for (NamableWithClass item : allCache) { | |||
| if (item.matches(this.query, matched)) { | |||
| suggestedItems.add(new SuggestedItem(new NestedViewsSearchResult(item.getUsefulName(), item.getUrl(), item.getProject(), null, null))); | |||
| suggestedItems.add(new SuggestedItem(new NestedViewsSearchResult(item.getUsefulName(), item.getUrl().replace(Jenkins.get().getRootUrl(), ""), item.getProject(), null, null))); | |||
There was a problem hiding this comment.
It seesm the absolute url was there since origin. The change, however hackisch, looks ok. I need to try it locally.
Would be good to get some input from the developers here. The test(s) as Command Palette isn't expecting absolute URLs, so search results link to
{rootURL}/{rootURL}/view/bla. I've adapted this by removingrootURLfrom search results, but I'm unsure on the wider implications of this.Testing done
Submitter checklist