Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Provide a default value of jenkins.addOpens for the benefit of IDEs #529

Merged
merged 2 commits into from
Apr 2, 2022
Merged

Provide a default value of jenkins.addOpens for the benefit of IDEs #529

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3fe702
Provide a default value of `jenkins.addOpens` for the benefit of IDEs
basil Apr 2, 2022
9ac2b01
Default value should not apply to Java 8
basil Apr 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,6 @@
<jenkins.version>2.249</jenkins.version>
<jenkins-bom.version>${jenkins.version}</jenkins-bom.version>

<!-- Filled in by "maven-hpi-plugin" from the "MANIFEST.MF" entry in "jenkins.war". -->
<jenkins.addOpens />
<!-- Filled in by "maven-hpi-plugin" with the path to "org-netbeans-insane-hook.jar" extracted from "jenkins-test-harness" -->
<jenkins.insaneHook />
<jenkins-test-harness.version>1731.v383b_5d6c3393</jenkins-test-harness.version>
Expand Down Expand Up @@ -940,16 +938,28 @@

<profiles>
<profile>
<id>jdk-above-9</id>
<id>jdk-8-and-below</id>
<activation>
<jdk>[1.9,)</jdk>
<jdk>(,1.8]</jdk>
</activation>
<properties>
<!-- Filled in by maven-hpi-plugin from the MANIFEST.MF entry in jenkins.war, but we provide a default value for the benefit of IDEs. -->
<jenkins.addOpens />
</properties>
</profile>
<profile>
<id>jdk-9-and-above</id>
<activation>
<jdk>[9,)</jdk>
</activation>
<properties>
<maven.compiler.release>8</maven.compiler.release>
<maven.compiler.testRelease>8</maven.compiler.testRelease>
<animal.sniffer.skip>true</animal.sniffer.skip>
<!-- Work around openjdk/jdk11u-dev#919. TODO When we upgrade to OpenJDK 11.0.16, this should be deleted. -->
<maven.compiler.forceJavacCompilerUse>true</maven.compiler.forceJavacCompilerUse>
<!-- Filled in by maven-hpi-plugin from the MANIFEST.MF entry in jenkins.war, but we provide a default value for the benefit of IDEs. -->
<jenkins.addOpens>--add-opens java.base/java.lang=ALL-UNNAMED --add-opens java.base/java.io=ALL-UNNAMED --add-opens java.base/java.util=ALL-UNNAMED</jenkins.addOpens>
</properties>
</profile>
<profile>
Expand Down