forked from vbehar/jenkins-rundeck-plugin
-
Notifications
You must be signed in to change notification settings - Fork 61
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #51 from jenkinsci/option-validate-artifact-acl
validate artifact ACL in OptionProvider
- Loading branch information
Showing
3 changed files
with
219 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
172 changes: 172 additions & 0 deletions
172
src/test/groovy/jenkinsci/plugins/rundeck/OptionProviderSpec.groovy
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,172 @@ | ||
| package jenkinsci.plugins.rundeck | ||
|
|
||
| import hudson.model.FreeStyleBuild | ||
| import hudson.model.Hudson | ||
| import hudson.model.Job | ||
| import hudson.model.Run | ||
| import hudson.security.AccessDeniedException2 | ||
| import hudson.util.RunList | ||
| import jenkins.model.Jenkins | ||
| import org.jenkinsci.plugins.rundeck.OptionProvider | ||
| import org.kohsuke.stapler.StaplerRequest | ||
| import org.kohsuke.stapler.StaplerResponse | ||
| import spock.lang.Specification | ||
|
|
||
| import javax.servlet.http.HttpServletResponse | ||
|
|
||
| import static hudson.model.Run.ARTIFACTS | ||
|
|
||
| class OptionProviderSpec extends Specification { | ||
|
|
||
| def originalHolder | ||
|
|
||
| def setup() { | ||
| originalHolder = Jenkins.HOLDER | ||
| System.properties['hudson.security.ArtifactsPermission'] = "true" | ||
| } | ||
|
|
||
| def cleanup() { | ||
| Jenkins.HOLDER = originalHolder | ||
| } | ||
|
|
||
| def "test option artifact without permissions"(){ | ||
|
|
||
| given: | ||
|
|
||
| final Hudson jenkins = Mock() | ||
| jenkins.getInstanceOrNull() >> jenkins | ||
| jenkins.getInstance() >> jenkins | ||
|
|
||
| def originalHolder = Jenkins.HOLDER | ||
|
|
||
| Jenkins.HOLDER = new Jenkins.JenkinsHolder() { | ||
| Jenkins getInstance() { | ||
| return jenkins | ||
| } | ||
| } | ||
|
|
||
| jenkins.getItemByFullName("test", _)>>Mock(Job) { | ||
| getLastSuccessfulBuild() >> Mock(FreeStyleBuild) { | ||
| checkPermission(ARTIFACTS) >> { throw new AccessDeniedException2(Jenkins.getAuthentication(), ARTIFACTS) } | ||
| } | ||
| } | ||
|
|
||
| def response = Mock(StaplerResponse) | ||
|
|
||
| when: | ||
| OptionProvider optionProvider = new OptionProvider() | ||
| def request = Mock(StaplerRequest){ | ||
| getParameter("project")>>"test" | ||
| getParameter("build")>>"lastSuccessful" | ||
| } | ||
|
|
||
| optionProvider.doArtifact(request,response ) | ||
|
|
||
| then: | ||
| 1 * response.sendError(HttpServletResponse.SC_BAD_REQUEST, {message-> message == "anonymous is missing the Run/Artifacts permission" }); | ||
|
|
||
|
|
||
| } | ||
|
|
||
| def "test option artifact with permissions"(){ | ||
|
|
||
| given: | ||
|
|
||
| final Hudson jenkins = Mock(){ | ||
| getRootUrl()>>"http://localhost:8080" | ||
| } | ||
|
|
||
| jenkins.getInstanceOrNull() >> jenkins | ||
| jenkins.getInstance() >> jenkins | ||
|
|
||
| Jenkins.HOLDER = new Jenkins.JenkinsHolder() { | ||
| Jenkins getInstance() { | ||
| return jenkins | ||
| } | ||
| } | ||
|
|
||
| jenkins.getItemByFullName("test", _)>>Mock(Job) { | ||
| getLastSuccessfulBuild() >> Mock(FreeStyleBuild) { | ||
| getArtifacts()>> [ | ||
| Mock(Run.Artifact){ | ||
| getFileName()>>"test-1.0.jar" | ||
| getHref()>>"artifact/test-1.0.jar" | ||
| } | ||
| ] | ||
| getUrl()>>"/rundeck/" | ||
| } | ||
| } | ||
|
|
||
| def writer = Mock(PrintWriter) | ||
| def response = Mock(StaplerResponse){ | ||
| getWriter()>>writer | ||
| } | ||
|
|
||
| when: | ||
| OptionProvider optionProvider = new OptionProvider() | ||
| def request = Mock(StaplerRequest){ | ||
| getParameter("project")>>"test" | ||
| getParameter("build")>>"lastSuccessful" | ||
| } | ||
| optionProvider.doArtifact(request,response ) | ||
|
|
||
| then: | ||
| 1*writer.append({json-> json == "[{\"name\":\"test-1.0.jar\",\"value\":\"http://localhost:8080/rundeck/artifact/artifact/test-1.0.jar\"}]"}) | ||
|
|
||
| } | ||
|
|
||
| def "test option build without permissions"(){ | ||
|
|
||
| given: | ||
|
|
||
| final Hudson jenkins = Mock() | ||
|
|
||
| jenkins.getInstanceOrNull() >> jenkins | ||
| jenkins.getInstance() >> jenkins | ||
|
|
||
| Jenkins.HOLDER = new Jenkins.JenkinsHolder() { | ||
| Jenkins getInstance() { | ||
| return jenkins | ||
| } | ||
| } | ||
|
|
||
| List builds = [ | ||
| Mock(FreeStyleBuild) { | ||
| getArtifacts()>> [ | ||
| Mock(Run.Artifact){ | ||
| getFileName()>>"test-1.0.jar" | ||
| getHref()>>"artifact/test-1.0.jar" | ||
| } | ||
| ] | ||
| getUrl()>>"/rundeck/" | ||
| checkPermission(ARTIFACTS) >> { throw new AccessDeniedException2(Jenkins.getAuthentication(), ARTIFACTS) } | ||
|
|
||
| } | ||
| ] | ||
|
|
||
| jenkins.getItemByFullName("test", _)>>Mock(Job) { | ||
| getBuilds()>> Mock(RunList){ | ||
| iterator()>>builds.iterator() | ||
| } | ||
| } | ||
|
|
||
| def writer = Mock(PrintWriter) | ||
| def response = Mock(StaplerResponse){ | ||
| getWriter()>>writer | ||
| } | ||
|
|
||
| when: | ||
| OptionProvider optionProvider = new OptionProvider() | ||
| def request = Mock(StaplerRequest){ | ||
| getParameter("project")>>"test" | ||
| getParameter("artifactRegex")>>".jar" | ||
| getParameter("build")>>"lastSuccessful" | ||
| } | ||
| def result = optionProvider.doBuild(request,response ) | ||
|
|
||
| then: | ||
| 1*writer.append({json-> json == "[]"}) | ||
|
|
||
| } | ||
|
|
||
| } |