Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[FIXED JENKINS-21467]. Tries to revert the file name for the original ... #27

Merged
merged 1 commit into from
Jan 24, 2014

Conversation

mathieu-pousse
Copy link
Contributor

...file system

I tested those cases:
Master Windows / Slave Windows
Master Windows / Slave Unix

Remains to be tested
Master Unix / Slave Windows
Master Unix / Slave Unix

@cloudbees-pull-request-builder

plugins » sloccount-plugin #39 SUCCESS
This pull request looks good

@mixalturek
Copy link
Contributor

Hi Mathieu,

thank you for the bug report and the patch, it was my fault :-/

I would suggest to evaluate the path on slave side (which should be safer) instead of on master, the related code is in class SloccountPublisherReport. We can transform sourceFiles member to List, where FileNamePath is a custom structure with two strings initialized to getName() and getAbsolutePath(). What do you think?

I will have time to look at it and release a new version at the end of this week at the earliest. I can test only Linux to Linux case.

Michal

@mathieu-pousse
Copy link
Contributor Author

Definitely, doing that on the slave will be much safer and much more consistent and working with String instead of File will avoid all the cross platform issues.

@jenkinsadmin
Copy link
Member

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

mixalturek added a commit that referenced this pull request Jan 24, 2014
[FIXED JENKINS-21467]. Tries to revert the file name for the original ...
@mixalturek mixalturek merged commit 2e8cb21 into jenkinsci:master Jan 24, 2014
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants