SECURITY-1686 - [TestComplete] Password stored in plain-text in confi…

…g.xml for job (Part 3)
jenkinsci · Aug 11, 2020 · 0098887 · 0098887
1 parent ca783d3
commit 0098887
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src/main/java/com/smartbear/jenkins/plugins/testcomplete/TcTestBuilder.java b/src/main/java/com/smartbear/jenkins/plugins/testcomplete/TcTestBuilder.java
@@ -1324,7 +1324,12 @@ public String getPluginName() {
 
         @Override
         public Builder newInstance(StaplerRequest req, @Nonnull JSONObject formData) throws FormException {
-            return super.newInstance(req, formData);
+            TcTestBuilder builder = (TcTestBuilder)super.newInstance(req, formData);
+            if (!StringUtils.isEmpty(builder.getCredentialsId())) {
+                builder.setUserName("");
+                builder.setUserPassword("");
+            }
+            return builder;
         }
 
         public FormValidation doCheckSuite(@QueryParameter String value) {