Update POMs and cleanup the dependencies/code #192
Conversation
|
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
| @@ -111,7 +111,8 @@ private String getUserId() { | |||
| final String userName = getSystemProperty(SYS_PROP_USER_NAME); | |||
| final String fakeUserId = MessageFormat.format("{0}@{1}", userName, computerName); | |||
|
|
|||
| return DigestUtils.sha1Hex(fakeUserId); | |||
| //FIXME: was sha1Hex, but this is available only in commons codec 1.7. TFS SDK 14.0.3 bundles older version | |||
There was a problem hiding this comment.
I don't think this needs to be fixed (i.e. you can remove the comment). The idea here is to keep the user id unique to the telemetry server, but not allow anyone to actually identify the user. So, as long as the user id is obfuscated, there shouldn't be a problem.
|
|
||
| <properties> | ||
| <!-- TODO: enable once FindBugs issues are fixed --> | ||
| <findbugs.failOnError>false</findbugs.failOnError> |
There was a problem hiding this comment.
Is this necessary? I hesitate to turn it off.
There was a problem hiding this comment.
With the current configuration you will be getting FindBugs warnings in the build log. They just won't fail the build.
I was working on PCT for JEP-200, and finally I discovered that the plugin build does not work there. In this PR i tried to cleanup the POMs and code a bit.
@reviewbybees