JENKINS-49965 "Slow performance of warnings table if there are 1000 elements" #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vidual row at the time of that row being drawn on the page"
|
I think this is hard to test, even in a UI test since it does depend on the number of items. |
|
On the other hand it actually will not harm to enable this option... |
|
I've installed the latest build for the PR and confirm that it works without any visible issues in a table with 2k+ items. I will do more testing with 10k+ issues.
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not exactly the ajax pagination but a simple hotfix to allow users use warnings ng plug-in even though they have much more than 1000+ elements in their warnings table.
Resource:
https://datatables.net/examples/ajax/defer_render.html
I am not sure how can I test this in action. It would be great having a way for getting *.hpi file and see it in our current Jenkins implementations with the builds more than 2k+ warnings.