implement Serializable

[ceefour]

No description provided.

[jeremiehuchet]

Hi,

Can you explain why do you need Serializable objects?

[ceefour]

Apache Wicket requires this in order for these objects to be stored on the stateful page store or session store.

[jeremiehuchet]

First of all : thank you for sharing :)

I am not comfortable to make this change : it does not add any feature to the library. I understand it is easier to store model objects from the library directly to your session.
However using you own model objects in your session gives you more control. That way you can make them serializable.
You can also get rid of everything you don't need from the library model objects.
And you can make your model perfectly adapted to your functional domain.
It is a pain to translate objects from on model to another. But there are some useful libraries like mapstruct.

If you still need this change, the best I can propose is to keep this PR opened until more people request it.

[ceefour]

I respect your decision.

However, have you thought carefully about the cons of making it Serializable ?

I can always create my own models myself. However sometimes I don't want to, perhaps because it's sufficient to just use it. I may store things like LocalDate on the session, even though I can create my own model in the session that basically wraps a LocalDate, but it'd be extra work without additional benefit.

Having your classes Serializable will provide value & benefit to people who appreciate the convenience of not having to do extra work to wrap your class. I already did the first extra work to make a pull request here.

Sun/Oracle making LocalDate (and lots of other classes) Serializable does not add any date-related feature to that class. But it sure does make other people's lives who need it easier, while not having undesirable effects.

I understand that some changes need careful thought, like bumping the minimum version to Java 8 or adding a 20 MB dependency. But I don't think that's the case here. Unless you provide a strong argument why it's undesirable to have Serializable, I don't see why not.

[jeremiehuchet]

Decision is not already made, discussion is opened.
Your arguments are relevant and convinced me :)