Fix #132 by respecting indent_size from .editorconfig #133
Conversation
Remove unused `continuationIndentSize`
There was a problem hiding this comment.
Thank you once again!
My best guess is the upgrade from ktlint 0.34.0 to 0.34.2 broke this behavior? I have a vague memory that they used to do the precedence the other way around and they corrected it.
https://github.com/pinterest/ktlint/pull/534/files#diff-99e7e840295caf6ea84c484c30d73158R140
| @@ -16,9 +14,7 @@ open class KotlinterExtension { | |||
| /** Don't fail build on lint issues */ | |||
| var ignoreFailures = DEFAULT_IGNORE_FAILURES | |||
|
|
|||
| var indentSize = DEFAULT_INDENT_SIZE | |||
|
|
|||
| var continuationIndentSize = DEFAULT_CONTINUATION_INDENT_SIZE | |||
There was a problem hiding this comment.
Good catch -- probably the right thing is remove it entirely in 3.0 -- leave the parameter so that nobody's gradle files blow up on upgrade, but print a WARN level output saying the setting is deprecated and does nothing.
There was a problem hiding this comment.
If you wish to remove it from the readme, you can or I'll make those updates when I push the version bump.
There was a problem hiding this comment.
Done ✅
Added deprecation messages, both for tasks and for the extension. Removed all continuationIndentSize references from Readme.
| } | ||
|
|
||
| @Test | ||
| fun `lintTask uses default indentation if editorconfig absent`() { |
There was a problem hiding this comment.
oh good, so that's ktlint default when there isn't userData or an .editorconfig.
src/test/kotlin/org/jmailen/gradle/kotlinter/functional/EditorConfigTest.kt
Show resolved
Hide resolved
mateuszkwiecinski
deleted the
feature/respect_indent_size_set_from_editorconfig
branch
Fixes #132
The reson why properties set in
.editorconfigweren't respected is that we were always passing them in ktlint's userData which are higher in hierarchy than those set in.editorconfig.In addition I removed support for
continuation_indent_sizeas it is no longer recognized by ktlint pinterest/ktlint#171 (I could mark it as deprecated though 🤔WDYT?)