Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bump Gradle 7.4.1, fix generateVersionProperties configuration-cache compatibility #241

Merged
merged 3 commits into from
Mar 30, 2022

Conversation

mateuszkwiecinski
Copy link
Contributor

@mateuszkwiecinski mateuszkwiecinski commented Mar 19, 2022

I wanted to bump ktlint version to fix/ #227, but I stumbled upon pinterest/ktlint#1421 which turned out to be a blocker :/

While investigating the issue, I noticed a warning/error saying:

1 problem was found storing the configuration cache.

In this PR I'm proposing to:

  1. Bump Gradle to current version
  2. Bump internal kotlinter dependency and run formatKotlin to have all offences autocorrected
  3. Declare inputs for generateVersionProperties task, so the build is compatible with configuration-cache
  4. Alter generateVersionProperties behavior and generate the properties file directly under build directory

@mateuszkwiecinski mateuszkwiecinski marked this pull request as ready for review March 19, 2022 13:10
Copy link
Owner

@jeremymailen jeremymailen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Good improvement

@jeremymailen jeremymailen merged commit 74b667e into jeremymailen:master Mar 30, 2022
@mateuszkwiecinski mateuszkwiecinski deleted the fix_configuration_cache branch March 30, 2022 09:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants