Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

infinit lock #28

Closed
NOMORECOFFEE opened this issue Nov 29, 2019 · 1 comment
Closed

infinit lock #28

NOMORECOFFEE opened this issue Nov 29, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@NOMORECOFFEE
Copy link

Describe the bug
forget to call wg.Done() and if we call Close() then we are lock on wg.Wait()
https://github.com/jeroenrinzema/commander/blob/master/dialects/kafka/consumer/group.go#L94
https://github.com/jeroenrinzema/commander/blob/master/dialects/kafka/consumer/group.go#L89

To Reproduce
Steps to reproduce the behavior. Please include code examples:

  1. Setup '...'
  2. Emit event '....'
  3. Await x seconds '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Desktop (please complete the following information):

  • OS: [e.g. Linux]
  • Golang version

Additional context
Add any other context about the problem here.

@NOMORECOFFEE NOMORECOFFEE added the bug Something isn't working label Nov 29, 2019
@jeroenrinzema
Copy link
Owner

Hi, thank you very much for reporting this race condition.

jeroenrinzema added a commit that referenced this issue Dec 5, 2019
jeroenrinzema added a commit that referenced this issue May 10, 2020
jeroenrinzema added a commit that referenced this issue May 10, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants