Consolidate test targets into single workspace #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ARC can be enabled with a per-file compiler flag (-fobjc-arc) so it's unnecessary to maintain two separate project code bases. Delete the Arc project and add a second target to the non-ARC project that enables ARC only on BSManagedDocument.
|
Any thoughts on merging this? If it looks okay it will simplify my testing workflow for the other pull requests. |
|
Well, I was thinking of taking my time, since I am in the middle of another slightly hairy mess. But now knowing your situation I shall pull it today, do some quick tests, approve the merge if no major issues, begin running it in my daily testing, and if any problems show up, deal with them later as new issues. Thank you for the nudge. I'm hoping your work might fix or shed light on a rare crash I'm still seeing. |
|
Thanks! No rush on the other stuff, they are certainly "dangerous" changes and belong on the slow / scenic route. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARC can be enabled with a per-file compiler flag (
-fobjc-arc) so it's unnecessary to maintain two separate project code bases. Delete the Arc project and add a second target to the non-ARC project that enables ARC only on BSManagedDocument.