Remove persistent store when closing document #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the persistent store is not manually removed, the file will be
unlinked while the SQLite file descriptor is still open, resulting
in these errors:
BUG IN CLIENT OF libsqlite3.dylib: database integrity compromised by
API violation: vnode unlinked while in use
Note that this change may result in crashes if client code attempts to
modify managed objects after document close (e.g. in dealloc methods
that access @sythesized relationships to other managed objects). This
client code will need to be fixed.
|
This PR also needs work - the error returned inside |
evanmiller
changed the title
|
I think this PR is ready for review now. |
evanmiller
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the persistent store is not manually removed, the file will be unlinked while the SQLite file descriptor is still open, resulting in errors described in evanmiller#2
Note that this PR may result in crashes if client code attempts to access managed objects after document close (e.g. in dealloc methods that access @sythesized relationships to other managed objects or key-value observers that look at managed objects). This client code will need to be fixed.