Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix lazydocker breaking when having default context in config #552

Merged
merged 1 commit into from
Jul 21, 2024

Conversation

peauc
Copy link
Contributor

@peauc peauc commented Jun 18, 2024

Fix issue #493

@peauc peauc changed the title fix lazydocker breaking when having default docker in config fix lazydocker breaking when having default context in config Jun 18, 2024
@peauc peauc force-pushed the feature/issue-493 branch from 40c16a2 to f6c044d Compare June 26, 2024 16:21
@jesseduffield jesseduffield merged commit c73b3f7 into jesseduffield:master Jul 21, 2024
5 checks passed
@jesseduffield
Copy link
Owner

Nice work @peauc !

@peauc peauc deleted the feature/issue-493 branch July 26, 2024 13:49
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Nov 25, 2024
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [jesseduffield/lazydocker](https://github.com/jesseduffield/lazydocker) | minor | `v0.23.3` -> `v0.24.1` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>jesseduffield/lazydocker (jesseduffield/lazydocker)</summary>

### [`v0.24.1`](https://github.com/jesseduffield/lazydocker/releases/tag/v0.24.1)

[Compare Source](jesseduffield/lazydocker@v0.24.0...v0.24.1)

Thanks to everybody who contributed in this release!

#### What's Changed

-   fix: Properly support remote docker daemon over ssh by [@&#8203;rajiv-k](https://github.com/rajiv-k) in jesseduffield/lazydocker#511
-   fix lazydocker breaking when having default context in config by [@&#8203;peauc](https://github.com/peauc) in jesseduffield/lazydocker#552
-   Bump lots of dependencies for various improvements by [@&#8203;thaJeztah](https://github.com/thaJeztah) in jesseduffield/lazydocker#561
    -   This fixed a bug I had where sometimes lazydocker didn't realise it was in a folder with a docker compose file.
-   Add hint to what .DockerCompose is in documentation by [@&#8203;hauskens](https://github.com/hauskens) in jesseduffield/lazydocker#554
-   Use 'docker compose' by default by [@&#8203;jesseduffield](https://github.com/jesseduffield) in jesseduffield/lazydocker#563
-   go.mod: github.com/docker/docker, docker/cli v27.1.1 by [@&#8203;thaJeztah](https://github.com/thaJeztah) in jesseduffield/lazydocker#568

#### New Contributors

-   [@&#8203;github-actions](https://github.com/github-actions) made their first contribution in jesseduffield/lazydocker#536
-   [@&#8203;peauc](https://github.com/peauc) made their first contribution in jesseduffield/lazydocker#552
-   [@&#8203;thaJeztah](https://github.com/thaJeztah) made their first contribution in jesseduffield/lazydocker#561
-   [@&#8203;hauskens](https://github.com/hauskens) made their first contribution in jesseduffield/lazydocker#554

**Full Changelog**: jesseduffield/lazydocker@v0.23.3...v0.24.1

### [`v0.24.0`](https://github.com/jesseduffield/lazydocker/releases/tag/v0.24.0)

[Compare Source](jesseduffield/lazydocker@v0.23.3...v0.24.0)

#### Changelog

-   [`015a108`](jesseduffield/lazydocker@015a108) Add hint to .DockerCompose in documentation
-   [`ed600c7`](jesseduffield/lazydocker@ed600c7) Dockerfile: fix alpine version
-   [`06ab7b7`](jesseduffield/lazydocker@06ab7b7) Merge pull request [#&#8203;511](jesseduffield/lazydocker#511) from rajiv-k/docker-host-ssh
-   [`1cf2e02`](jesseduffield/lazydocker@1cf2e02) Merge pull request [#&#8203;536](jesseduffield/lazydocker#536) from jesseduffield/create-pull-request/patch
-   [`c73b3f7`](jesseduffield/lazydocker@c73b3f7) Merge pull request [#&#8203;552](jesseduffield/lazydocker#552) from peauc/feature/issue-493
-   [`4f375bb`](jesseduffield/lazydocker@4f375bb) Merge pull request [#&#8203;554](jesseduffield/lazydocker#554) from hauskens/patch-1
-   [`0849b80`](jesseduffield/lazydocker@0849b80) Merge pull request [#&#8203;561](jesseduffield/lazydocker#561) from thaJeztah/update_docker
-   [`de40167`](jesseduffield/lazydocker@de40167) Merge pull request [#&#8203;563](jesseduffield/lazydocker#563) from jesseduffield/docker-compose-command-update
-   [`58d5a18`](jesseduffield/lazydocker@58d5a18) README.md: Update Sponsors
-   [`1e34a9b`](jesseduffield/lazydocker@1e34a9b) Remove homebrew bump action
-   [`89020d6`](jesseduffield/lazydocker@89020d6) Update readme
-   [`df6c8c1`](jesseduffield/lazydocker@df6c8c1) Use 'docker compose' by default
-   [`f6c044d`](jesseduffield/lazydocker@f6c044d) fix lazydocker breaking when having default docker explicitly mentioned in docker config
-   [`42b7ba1`](jesseduffield/lazydocker@42b7ba1) fix: Properly support remote docker daemon over ssh
-   [`8fe9083`](jesseduffield/lazydocker@8fe9083) go.mod: github.com/Microsoft/go-winio v0.5.3
-   [`966ad05`](jesseduffield/lazydocker@966ad05) go.mod: github.com/docker/docker, docker/cli v23.0.10
-   [`6f85b65`](jesseduffield/lazydocker@6f85b65) go.mod: github.com/docker/docker, docker/cli v24.0.7
-   [`0232610`](jesseduffield/lazydocker@0232610) go.mod: github.com/docker/docker, docker/cli v25.0.5
-   [`2d16389`](jesseduffield/lazydocker@2d16389) go.mod: github.com/docker/docker, docker/cli v26.1.4
-   [`77a4de4`](jesseduffield/lazydocker@77a4de4) go.mod: github.com/docker/docker, docker/cli v27.0.3
-   [`463ddfd`](jesseduffield/lazydocker@463ddfd) go.mod: github.com/docker/go-connections v0.5.0
-   [`3daea1e`](jesseduffield/lazydocker@3daea1e) go.mod: github.com/docker/go-units v0.5.0
-   [`8ca3166`](jesseduffield/lazydocker@8ca3166) go.mod: github.com/imdario/mergo v0.3.16
-   [`e27d487`](jesseduffield/lazydocker@e27d487) go.mod: github.com/moby/term v0.5.0
-   [`61cd92b`](jesseduffield/lazydocker@61cd92b) go.mod: github.com/morikuni/aec v1.0.0
-   [`6217ba0`](jesseduffield/lazydocker@6217ba0) go.mod: github.com/sirupsen/logrus v1.9.3
-   [`ff579d8`](jesseduffield/lazydocker@ff579d8) go.mod: github.com/stretchr/testify v1.9.0
-   [`bb5d70f`](jesseduffield/lazydocker@bb5d70f) go.mod: golang.org/x/time v0.5.0
-   [`b010ea4`](jesseduffield/lazydocker@b010ea4) test.sh: fix file not being executable
-   [`c84bb88`](jesseduffield/lazydocker@c84bb88) update to go1.21

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants