New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Improve Dockerfile #4447

Open

aaron0x wants to merge 3 commits into jesseduffield:master from aaron0x:improve-docker

aaron0x commented Apr 1, 2025 •

edited

Loading

PR Description
This PR introduces improvements to the Dockerfile:

Use the vendor folder for dependencies: Since we're already using vendoring for Go modules, we now ensure the build uses the vendor directory for dependencies.
Fix Docker build warning: Corrects the casing issue between the FROM and as keywords (line 5) to resolve the FromAsCasing warning during docker build.
Fix invalid lazygit argument in Docker command: Resolves the error related to the invalid lazygit argument (/bin/sh).

Please check if the PR fulfills these requirements

Cheatsheets are up-to-date (run go generate ./...)
Code has been formatted (see here)
Tests have been added/updated (see here for the integration test guide)
Text is internationalised (see here)
If a new UserConfig entry was added, make sure it can be hot-reloaded (see here)
Docs have been updated if necessary
You've read through your own file changes for silly mistakes etc

aaron0x added 3 commits

April 1, 2025 15:29


          Use vendor folder with go build in Dockerfile

519f71a


          Fix "casing do not match" warning during docker build

fbf72cd


          Fix run example in Dockerfile

9fde0bc

# for free to join this conversation on GitHub. Already have an account? # to comment

Labels

None yet