Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Make more "swifty" #120

Closed
jessesquires opened this issue Jan 10, 2018 · 0 comments
Closed

Make more "swifty" #120

jessesquires opened this issue Jan 10, 2018 · 0 comments
Labels
enhancement
Milestone
8.0.0

Comments

@jessesquires
Copy link
Owner

There are lots of free functions that really should be extension methods instead.

Historically, this wasn't clear at the time. these are an artifact of early Swift, before we knew what "swifty" really meant.

These will be breaking changes.
@jessesquires jessesquires added this to the 8.0.0 milestone Jan 10, 2018
jessesquires added a commit that referenced this issue Nov 5, 2018
@jessesquires
Make APIs more "swifty"
106b21d 
- Nest top-level function `defaultDirectoryURL()` under `CoreDataModel`
- Nest `ChildContext` typealias under `NSManagedObjectContext` extension
- Move `saveContext()` top-level function to extension method on `NSManagedObjectContext`
- Use `Equatable` auto-synthesis where possible

Closes #120
@jessesquires jessesquires mentioned this issue Nov 5, 2018
Merged
jessesquires added a commit that referenced this issue Nov 5, 2018
@jessesquires
Make APIs more "swifty"
b6003eb 
- Nest top-level function `defaultDirectoryURL()` under `CoreDataModel`
- Nest `ChildContext` typealias under `NSManagedObjectContext` extension
- Move `saveContext()` top-level function to extension method on `NSManagedObjectContext`
- Use `Equatable` auto-synthesis where possible

Closes #120
jessesquires added a commit that referenced this issue Nov 5, 2018
@jessesquires
Make APIs more "swifty"
d7972c8 
- Nest top-level function `defaultDirectoryURL()` under `CoreDataModel`
- Nest `ChildContext` typealias under `NSManagedObjectContext` extension
- Move `saveContext()` top-level function to extension method on `NSManagedObjectContext`
- Use `Equatable` auto-synthesis where possible

Closes #120
jessesquires added a commit that referenced this issue Nov 5, 2018
@jessesquires
Make APIs more "swifty"
abaa21d 
- Nest top-level function `defaultDirectoryURL()` under `CoreDataModel`
- Nest `ChildContext` typealias under `NSManagedObjectContext` extension
- Move `saveContext()` top-level function to extension method on `NSManagedObjectContext`
- Use `Equatable` auto-synthesis where possible

Closes #120
jessesquires added a commit that referenced this issue Nov 5, 2018
@jessesquires
Make APIs more "swifty" (#128)
b8f4997 
- Nest top-level function `defaultDirectoryURL()` under `CoreDataModel`
- Nest `ChildContext` typealias under `NSManagedObjectContext` extension
- Move `saveContext()` top-level function to extension method on `NSManagedObjectContext`
- Use `Equatable` auto-synthesis where possible

Closes #120
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
8.0.0
Development

No branches or pull requests
1 participant
@jessesquires