-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Added Framework Search Paths to ExampleModel project (#100) #101
Conversation
Thanks @darkhonor ! |
I don't think this is the correct solution to the problem at hand. Unless Carthage needs to run tests, it shouldn't be building the example models. You probably want to make the schemes for the example models not shared. Carthage doesn't build any targets that don't have shared schemes. |
Thanks @tonyarnold! -- Yeah, that was my initial reaction. Then I realized that schemes need to be shared for travis. So I was like Maybe we don't need this: since that |
I'll pull it out of my branch, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@darkhonor Let's try:
- Revert these changes
- Make
ExampleModel
not shared
Made ExampleModel not shared
Current coverage is 90.36% (diff: 100%)@@ develop #101 diff @@
==========================================
Files 13 13
Lines 394 394
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 356 356
Misses 38 38
Partials 0 0
|
@jessesquires , made the suggested changes. Let me know what you think |
Thanks @darkhonor ! The first commit is still in here, but it looks like #102 takes care of that + updating travis. Going to close this in favor of #102, but we'll still give you credit in the release notes! 😄 |
Pull request checklist
This fixes issue #100
What's in this pull request?
Added Search Framework Path to the ExampleModel project to locate the JSQCoreDataKit.framework built during carthage build