Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added Framework Search Paths to ExampleModel project (#100) #101

Closed
wants to merge 4 commits into from

Conversation

darkhonor
Copy link

Pull request checklist

This fixes issue #100

What's in this pull request?

Added Search Framework Path to the ExampleModel project to locate the JSQCoreDataKit.framework built during carthage build

@jessesquires
Copy link
Owner

Thanks @darkhonor !

@jessesquires jessesquires added this to the 6.0.1 milestone Oct 25, 2016
@tonyarnold
Copy link
Collaborator

I don't think this is the correct solution to the problem at hand. Unless Carthage needs to run tests, it shouldn't be building the example models. You probably want to make the schemes for the example models not shared. Carthage doesn't build any targets that don't have shared schemes.

@jessesquires
Copy link
Owner

Thanks @tonyarnold! -- Yeah, that was my initial reaction. Then I realized that schemes need to be shared for travis. So I was like ¯\_(ツ)_/¯

Maybe we don't need this:
https://github.com/jessesquires/JSQCoreDataKit/blob/develop/.travis.yml#L47

since that ExampleModel project should get built implicitly via the Example project...

@tonyarnold
Copy link
Collaborator

I'll pull it out of my branch, xcodebuild should handle it for us.

Copy link
Owner

@jessesquires jessesquires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@darkhonor Let's try:

  • Revert these changes
  • Make ExampleModel not shared

@codecov-io
Copy link

Current coverage is 90.36% (diff: 100%)

Merging #101 into develop will not change coverage

@@            develop       #101   diff @@
==========================================
  Files            13         13          
  Lines           394        394          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            356        356          
  Misses           38         38          
  Partials          0          0          

Sunburst

Powered by Codecov. Last update e4c4abc...b2278ce

@darkhonor
Copy link
Author

@jessesquires , made the suggested changes. Let me know what you think

@jessesquires
Copy link
Owner

Thanks @darkhonor !

The first commit is still in here, but it looks like #102 takes care of that + updating travis.

Going to close this in favor of #102, but we'll still give you credit in the release notes! 😄

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants