Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

update path of golint install #283

Merged
merged 3 commits into from
Oct 29, 2018
Merged

update path of golint install #283

merged 3 commits into from
Oct 29, 2018

Conversation

XenoPhex
Copy link
Contributor

  • the "go get" was failing in travis, switching to path in golint
    readme.

@XenoPhex
update path of golint install
91547d5 
- the "go get" was failing in travis, switching to path in golint
readme.
@XenoPhex
add verbose to debug go get errors
53e309b
@XenoPhex
Copy link
Contributor Author

@jessevdk looks like golint no longer supports GoLang below 1.9: golang/lint#421

What would you prefer:

  1. Detecting the version of GoLang in the script section and then installing/running golint.
  2. Removing 1.7.x and 1.8.x from the .travis.yml.

Considering golang only has an n-2 support window, it would make sense to drop support for old versions of GoLang.

@XenoPhex XenoPhex mentioned this pull request Oct 24, 2018
Merged
@jessevdk jessevdk mentioned this pull request Oct 29, 2018
Closed
@jessevdk
Copy link
Owner

Went for 2)

@jessevdk jessevdk merged commit 5de817a into jessevdk:master Oct 29, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XenoPhex @jessevdk