fix(valid-describe): false positive with template describe.each (#785)

jest-community · Mar 8, 2021 · aa946a6 · aa946a6
1 parent 104e771
commit aa946a6
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/src/rules/__tests__/valid-describe.test.ts b/src/rules/__tests__/valid-describe.test.ts
@@ -50,6 +50,13 @@ ruleTester.run('valid-describe', rule, {
       if (hasOwnProperty(obj, key)) {
       }
     `,
+    dedent`
+    describe.each\`
+    something | other
+    ${1} | ${2} |
+    \`
+    ("$something", ({ something, other }) => { });
+    `,
   ],
   invalid: [
     {

diff --git a/src/rules/valid-describe.ts b/src/rules/valid-describe.ts
@@ -45,7 +45,10 @@ export default createRule({
   create(context) {
     return {
       CallExpression(node) {
-        if (!isDescribe(node)) {
+        if (
+          !isDescribe(node) ||
+          node.callee.type === AST_NODE_TYPES.TaggedTemplateExpression
+        ) {
           return;
         }