Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

New rule prefer-to-contain #100

Closed
kentor opened this issue Mar 10, 2018 · 2 comments · Fixed by #174 or severest/retrobot#245
Closed

New rule prefer-to-contain #100

kentor opened this issue Mar 10, 2018 · 2 comments · Fixed by #174 or severest/retrobot#245
Labels
good first issue help wanted new rule

Comments

@kentor
Copy link

kentor commented Mar 10, 2018

Prefer expect(a).toContain(b) rather than expect(a.includes(b)).toBe(true).

The error messages are often times better.

This rule is similar to prefer-to-have-length.
@thymikee
Copy link
Member

Seems like a nice rule to add!

@katakonst katakonst mentioned this issue Oct 8, 2018
Merged
SimenB pushed a commit that referenced this issue Oct 14, 2018
@katakonst @SimenB
feat: add prefer-to-contain rule (#174)
83a4c48 
Fixes #100
@SimenB
Copy link
Member

SimenB commented Oct 14, 2018

🎉 This issue has been resolved in version 21.25.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@dependencies dependencies bot mentioned this issue Oct 15, 2018
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
good first issue help wanted new rule
Projects
None yet
Milestone
No milestone
3 participants
@kentor @SimenB @thymikee