Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Include globals and 'jest' plugin in recommended #37

Closed
scriptdaemon opened this issue Dec 15, 2017 · 1 comment
Closed

Include globals and 'jest' plugin in recommended #37

scriptdaemon opened this issue Dec 15, 2017 · 1 comment

Comments

@scriptdaemon
Copy link
Contributor

scriptdaemon commented Dec 15, 2017

I propose that the following be added to the "recommended" config option:

plugins: [
  'jest'
],
env: {
  'jest/globals': true
}

That way, when extending the recommended settings, a user does not have to include these manually. Both eslint-config-standard and eslint-plugin-vue (and probably others) do this as well. I'll submit the PR if this proposal is accepted.

@SimenB
Copy link
Member

SimenB commented Dec 15, 2017

React plugin does it as well, so I'm +1. PR welcome 🙂

scriptdaemon added a commit to scriptdaemon/eslint-plugin-jest that referenced this issue Dec 15, 2017
Add the 'jest' plugin and 'jest/globals' environment to the recommended
config so the user doesn't have to include these manually.

Closes jest-community#37
@SimenB SimenB closed this as completed in 446fe79 Dec 15, 2017
scriptdaemon added a commit to scriptdaemon/eslint-plugin-jest that referenced this issue Dec 15, 2017
Add the 'jest' plugin and 'jest/globals' environment to the recommended
config so the user doesn't have to include these manually.

Closes jest-community#37
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants