Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

valid-describe blows up on template strings (backticks) #75

Closed
nevir opened this issue Feb 13, 2018 · 3 comments · Fixed by severest/retrobot#29
Closed

valid-describe blows up on template strings (backticks) #75

nevir opened this issue Feb 13, 2018 · 3 comments · Fixed by severest/retrobot#29

Comments

@nevir
Copy link

nevir commented Feb 13, 2018

I have a pattern where I prefer backticks for test/describe names (makes apostrophes easier to juggle, and helps call out strings that are user-visible vs those that aren't)

However, valid-describe blows up on 'em:

describe(`foo`, () => {  }); // Error: First argument must be name
describe('foo', () => {  }); // OK
@macklinu
Copy link
Collaborator

Thanks for the bug report - I'll open a PR to address this case in valid-describe. 👍

@SimenB
Copy link
Member

SimenB commented Feb 13, 2018

@nevir The fix should be available within 5 minutes 🙂

@nevir
Copy link
Author

nevir commented Feb 13, 2018 via email

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
3 participants