refactor(expect-expect): clean up and use ESQuery syntax #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macklinu
commented
Oct 2, 2018
| 'CallExpression[callee.name=/^it|test$/]'(node) { | ||
| unchecked.push(node); | ||
| }, | ||
| [`CallExpression[callee.name=/^${assertFunctionNames.join('|')}$/]`]() { |
There was a problem hiding this comment.
This statement replaces the isExpectCall() function (same behavior).
| }, | ||
| [`CallExpression[callee.name=/^${assertFunctionNames.join('|')}$/]`]() { | ||
| // Return early in case of nested `it` statements. | ||
| for (const ancestor of context.getAncestors()) { |
There was a problem hiding this comment.
I moved from using Array#some() to using a for..of loop because it felt more semantically correct. When we find the element we are looking for, call unchecked.splice() then break, instead of returning true in Array#some().
SimenB
approved these changes
Oct 2, 2018
|
🎉 This PR is included in version 21.24.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors to use selector syntax. Open to feedback on if this is a helpful refactor! 😄
Relates to #158, #169, #170