-
-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
improve includeSameMembers
error message
#640
base: main
Are you sure you want to change the base?
improve includeSameMembers
error message
#640
Conversation
🦋 Changeset detectedLatest commit: f50a1bc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #640 +/- ##
===========================================
- Coverage 100.00% 99.21% -0.79%
===========================================
Files 73 73
Lines 674 767 +93
Branches 290 315 +25
===========================================
+ Hits 674 761 +87
- Misses 0 6 +6 ☔ View full report in Codecov by Sentry. |
The failures are coverage failures just wanna get some feedback before putting the time fixing them |
Cc @SimenB |
Ping 😄 |
Cc @keeganwitt |
Any update on this? The current output is unusable as soon as you have a big array or "big" objects in it |
@SebTVisage Until and if the related PR gets merged I created an npm package with that matcher and the better output: |
I'll try to take a look at this. |
Thank you After this is merged I will create a performance improvement for that function for primitive values |
@SimenB any thoughts on this idea? |
What
Improve the error message in case actual and expected do not match
Why
#639
Notes
Before I add the matching coverage I would appreciate a review as there may be some resistant...
Housekeeping
How would it look like:
For the following tests:
Tests
This is the result:
Current
old.mov
After this PR
new.mov