fix(cli-options): rules should be passed as an object instead of array of strings

[emmenko]

Fixes: #27 (comment)

In the ESLint docs for the CLIEngine clearly states that rules is a JSON object and not an array of strings.

The "string" version (e.g. --rule "quotes: [2, double]") is only used by the CLI. When the args are parsed, the rule is also a JSON object.

In the case of this library, the jest-runner-eslint.config.js is a js file, so we can pass an object directly.

module.exports = {
  cliOptions: {
    format: 'node_modules/eslint-formatter-pretty',
    rules: {
      'import/no-unresolved': 2,
      'prettier/prettier': [
        'error',
        { trailingComma: 'es5', singleQuote: true },
      ],
    },
  },
};

Now ESLint properly receives the additional rules.

[tdeekens]

Thanks a lot for the fix. Any update or release plan on this? Would love to use this fix on a side project of mine too.

[emmenko]

@rogeliog any chance we can get this merged? 😇

[rogeliog]

I just published it under 0.6.0-0, let me know how it works for you and I'll promote it to 0.6.0

[tdeekens]

Thanks. Note: I am a colleague of @emmenko.

1. Tried it out on our project where we until now used @emmenko fork ➡ works as expected
2. Tried it out on a side project of mine (where I don't use CLI options ➡ works fine as well

[emmenko]

Awesome, thanks a lot! 🙌

[rogeliog]

Awesome, just published 0.6.0 😄

[tdeekens]

Horray. Thanks all. #teamwork