Add support for plugin config #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
approved these changes
Jul 4, 2018
|
Available in Jest 23.3.0, so should be good to go 🙂 |
SimenB
reviewed
Jul 4, 2018
src/file_name_plugin.js
Outdated
|
|
||
| constructor({ | ||
| stdin, | ||
| stdout, | ||
| config, |
SimenB
reviewed
Jul 4, 2018
src/file_name_plugin.js
Outdated
| @@ -48,8 +57,8 @@ class FileNamePlugin { | |||
| // eslint-disable-next-line class-methods-use-this | |||
| getUsageInfo() { | |||
| return { | |||
| key: 'p', | |||
| prompt: 'filter by a filename regex pattern', | |||
| key: this._config.key || 'p', | |||
There was a problem hiding this comment.
check in constructor and assign there?
There was a problem hiding this comment.
Sounds like a good idea? Do you mean assigning the this._key and this._prompt as instance variables?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on jestjs/jest#6603