-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Support custom snapshot serializers on diff inputs #30
Comments
Happy to review, seems like a handy feature. Serializers are just pretty-format plugins, so hopefully this will be pretty straight-forward to implement. @SimenB @pedrottimark are you ok with the API proposal? I thought about |
Yeah, that sounds good! |
Any updates on this? :-) |
alistairjcbrown
added a commit
to alistairjcbrown/snapshot-diff
that referenced
this issue
Sep 15, 2019
Provides new addSerializers function to add additional serializer objects to be used before diffing. Fixes jest-community#18 Fixes jest-community#30
alistairjcbrown
added a commit
to alistairjcbrown/snapshot-diff
that referenced
this issue
Sep 15, 2019
Provides new addSerializers function to add additional serializer objects to be used before diffing. React component serializer implementation using `react-test-renderer` has been extracted out. Fixes jest-community#18 Fixes jest-community#30
alistairjcbrown
added a commit
to alistairjcbrown/snapshot-diff
that referenced
this issue
Sep 23, 2019
Provides new setSerializers function to set the serializer objects to be used before diffing. React component serializer implementation using `react-test-renderer` has been extracted out. Fixes jest-community#18 Fixes jest-community#30 Fixes jest-community#31
alistairjcbrown
added a commit
to alistairjcbrown/snapshot-diff
that referenced
this issue
Sep 23, 2019
Provides new setSerializers function to set the serializer objects to be used before diffing. React component serializer implementation using `react-test-renderer` has been extracted out. Fixes jest-community#18 Fixes jest-community#30 Fixes jest-community#31
alistairjcbrown
added a commit
to alistairjcbrown/snapshot-diff
that referenced
this issue
Nov 4, 2019
Provides new setSerializers function to set the serializer objects to be used before diffing. React component serializer implementation using `react-test-renderer` has been extracted out. Fixes jest-community#18 Fixes jest-community#30 Fixes jest-community#31
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
My exact use case for this involves migrating from
react-test-renderer
toenzyme.mount
- the former is natively supported bypretty-format
while the latter ships with a custom serializer.Would it make sense for
snapshot-diff
to support an API similar toexpect.addSnapshotSerializer
? Maybe with a slightly more hygienic twist:I'm happy to put together a PR for this over the next few days.
The text was updated successfully, but these errors were encountered: