-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix:-Simplified the Jest-haste-map API #13237
Conversation
Great minds.. ;) #13023 |
its funny how both PRs look identical, indeed great minds think the same |
hey @Smrtnyk could you help me with the lint issues! |
@SimenB could you provide some direction with the duplicate import error, could not figure out something that can work! |
@@ -10,6 +10,7 @@ import * as path from 'path'; | |||
import * as fs from 'graceful-fs'; | |||
import {sync as resolveSync} from 'resolve'; | |||
import {ModuleMap} from 'jest-haste-map'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe import { type IModuleMap, ModuleMap} from 'jest-haste-map'
;
I am not very familiar with eslint rules in jest repo @Biki-das but maybe it follows the above convention
Yeah, let's land #13023 👍 |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Tried scratching The Jest-haste-map api and seems like the majority of it is unused and also no mention in docs too, we can simplify the api further which is what this PR is done for