chore(build): make writefile path compatible posix and windows system #13270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Gareth Jones <Jones258@Gmail.com>
G-Rath
reviewed
Sep 16, 2022
scripts/bundleTs.mjs
Outdated
Comment on lines
203
to
204
| const {sep} = path; | ||
| const replaceDirReg = new RegExp(`(?<=\\${sep})(dist)(?=\\${sep})`); |
There was a problem hiding this comment.
@SimenB you'll need to remove this line too
Suggested change
| const {sep} = path; | |
| const replaceDirReg = new RegExp(`(?<=\\${sep})(dist)(?=\\${sep})`); | |
| const {sep} = path; |
SimenB
changed the title
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
make writefile path compatible posix and windows system
Closes #13204
Test plan