-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat(jest-snapshot): Support Error.cause in snapshots #13965
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I wonder if this should be considered a breaking change? If people snapshot errors with causes today, their snapshots will break with this change...
It will definitely be a breaking change 🤔 |
Needs rebase on |
@SimenB let me know when you want to merge it. I'll rebase it when ok to be merged |
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
@dubzzz hiya 👋 could you sign the CLA? 🙂 |
Thanks a lot @SimenB |
Yes of course I'll |
Done 👍 |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Up to now, the "error with cause" was not fully supported in snapshots. This PR adds support for it!
Fixes #11935
Test plan
Some dedicated E2E tests have been added to cover the feature.