Skip to content

Conversation

jayvdb
Copy link
Contributor

@jayvdb jayvdb commented Dec 5, 2024

Summary

exit has no license metadata at https://www.npmjs.com/package/exit , triggering license checkers

Attempts to resolve this have failed. cowboy/node-exit#18

exit-x has been created by gruntjs team to move forward. https://github.com/gruntjs/node-exit-x

Test plan

Copy link

linux-foundation-easycla bot commented Dec 5, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: jayvdb / name: John Vandenberg (8dee5ea)
  • ✅ login: SimenB / name: Simen Bekkhus (63dd4c5, b13de82)

Copy link

netlify bot commented Dec 5, 2024

Deploy Preview for jestjs ready!

Name Link
🔨 Latest commit b13de82
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/6788fa600991470008b7e9a4
😎 Deploy Preview https://deploy-preview-15399--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jayvdb
Copy link
Contributor Author

jayvdb commented Jan 16, 2025

hi @SimenB , are these failures ok? They look similar to #15422

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB
Copy link
Member

SimenB commented Jan 16, 2025

hi @SimenB , are these failures ok? They look similar to #15422

Yeah, should be fixed on main now, so I merged it in

@SimenB SimenB enabled auto-merge (squash) January 16, 2025 12:24
@SimenB SimenB merged commit 2076548 into jestjs:main Jan 16, 2025
84 checks passed
mohammednumaan pushed a commit to mohammednumaan/jest that referenced this pull request Jan 17, 2025
@SimenB
Copy link
Member

SimenB commented Jan 30, 2025

@jayvdb jayvdb deleted the replace-exit branch February 1, 2025 21:17
Copy link

github-actions bot commented Mar 4, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2025
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants