-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
Clear scrollback on terminal clear in watch mode #2230
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
And, yup, this PR is related and should close #1861 |
Current coverage is 89.36% (diff: 100%)@@ master #2230 diff @@
==========================================
Files 39 39
Lines 1467 1467
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 1311 1311
Misses 156 156
Partials 0 0
|
I'll take a look at this next week. I want to test it thoroughly but my schedule is just too packed right now and I need more time. |
Will this work correctly in a tmux pane as well? |
@SimenB yes. from 1.6 version link to tmux changes file:
|
Awesome, thanks for digging that up! |
LGTM. |
* Send reset screen symbol instead of clear * Use other symbol for clearing terminal on Windows * Clear remaining screen on linux/os x
* Send reset screen symbol instead of clear * Use other symbol for clearing terminal on Windows * Clear remaining screen on linux/os x
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
simply tweak clear codes and check 'em in different envs
main purpose was to clear scrollback buffer, instead of just clearing screen
Summary
clear scroll back on watch mode. helps a lot if you have output which you want to scroll up
Test plan
tested with this diff just to show that I have patched version of jest running:
on each test, I have to add
jest/packages
toNODE_PATH
and donpm link
inside ofjest/packages/jest-cli
, to make patchedjest
available globallythen run
jest --version
just to ensure that I'm running my patched version, and then, finally, runjest --watch
checked on:
(sorry, no videos nor gifs. removed them)
I think I have not break anything with this change. However, windows 10 with powershell is untested. Do you want me to test it also, @cpojer ?
And, cc @gaearon , please take a look on this PR.
P.S. However, I don't have GUI Linux and can't check on it...