-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
Use a better console-clearing string on Windows #5251
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
Maybe create some "console-clear" npm package? |
Do CI failures make sense to you? |
No... We get that error from time to time (currently why master is red on Travis). I think @aaronabramov had some theories at one point, not sure what came of it, though. |
Thanks! Do you mind testing this on a real windows computer before we merge this? |
I will. Let me grab a loaner. |
Just tested on Windows again, it definitely works while the previous sequence doesn't. |
Codecov Report
@@ Coverage Diff @@
## master #5251 +/- ##
=======================================
Coverage 61.14% 61.14%
=======================================
Files 203 203
Lines 6843 6843
Branches 3 3
=======================================
Hits 4184 4184
Misses 2658 2658
Partials 1 1
Continue to review full report at Codecov.
|
New CI passed... I really don't like that the ansi codes seem to sometimes be missing |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This is pretty much the same as facebook/create-react-app#2071.
It seems to work better for more recent Windows versions (according to my testing in facebook/create-react-app#2071 (comment) which I did a few months ago). I haven't verified this again but I can re-test with a Windows laptop in a few days.