chore: run some jsdom tests in leak check #9938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
commented
May 1, 2020
| @@ -107,7 +107,7 @@ | |||
| "test-ci": "yarn jest-coverage --color -i --config jest.config.ci.js && yarn test-leak && node ./scripts/mapCoverage.js && codecov", | |||
| "test-ci-partial": "yarn jest --color -i --config jest.config.ci.js", | |||
| "test-pretty-format-perf": "node packages/pretty-format/perf/test.js", | |||
| "test-leak": "yarn jest -i --detectLeaks jest-mock jest-diff jest-repl", | |||
| "test-leak": "yarn jest -i --detectLeaks jest-mock jest-diff jest-repl pretty-format", | |||
There was a problem hiding this comment.
pretty-format has some tests for dom serialization, those use jsdom
Codecov Report
@@ Coverage Diff @@
## master #9938 +/- ##
==========================================
- Coverage 64.13% 64.11% -0.02%
==========================================
Files 291 291
Lines 12447 12447
Branches 3068 3070 +2
==========================================
- Hits 7983 7981 -2
- Misses 3820 3821 +1
- Partials 644 645 +1
Continue to review full report at Codecov.
|
jeysal
added a commit
to jeysal/jest
that referenced
this pull request
May 2, 2020
…hile-running * upstream/master: (331 commits) chore: update ts-eslint (jestjs#9953) Updated config docs with default transform value (jestjs#8583) Update jest-phabricator documentation (jestjs#8662) chore: remove dependency on `realpath-native` (jestjs#9952) chore: bump dated dependencies (jestjs#9951) chore: another try at fixing test-utils dependency chore: update lockfile due to beta release chore: move changelog entry and fix tets utils dependency Fix time duration formatting as per SI (jestjs#9765) v26.0.0-alpha.0 chore: run some jsdom tests in leak check (jestjs#9938) chore: upgrade chalk to v4 (jestjs#9752) feat: upgrade to JSDOM 16 (jestjs#9606) chore: remove checks for compileFunction (jestjs#9949) chore: drop node 8 support (jestjs#9423) Remove leftover `providesModuleNodeModules` (jestjs#9948) [BREAKING] Pojer -> Nakazawa chore: revert lockfile changes from 2b32fe6 chore: move changelog entry and fix lint Remove `providesModuleNodeModules` from Jest. (jestjs#9583) ...
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This should allow us to detect if JSDOM starts leaking.
That said, it leaks now so we cannot land this.
EDIT: v13 does not leak, v14 and v15 does. v16 does not leak though, so let's merge this after #9606
Test plan
Green CI at some point