Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: use architecture as part of cache key #36

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

abbudao
Copy link
Contributor

@abbudao abbudao commented Feb 26, 2024

Use architecture as part of the cache key to avoid bad cache hits. The current implementation can crash pipelines using matrix strategies or when different pipelines use different architectures but leverage the Devbox action.

Fixes: #35

action.yml Outdated Show resolved Hide resolved
Co-authored-by: Lucille Hua <lucille.hua@jetpack.io>
Signed-off-by: Pedro Morello Abbud <abbudao@gmail.com>
@LucilleH
Copy link
Contributor

LucilleH commented Mar 2, 2024

Waiting for the team to revert a backward incompatible change before re-running the test

@LucilleH
Copy link
Contributor

LucilleH commented Mar 4, 2024

@abbudao do you mind rebasing on the latest main?

@LucilleH LucilleH added this pull request to the merge queue Mar 18, 2024
Merged via the queue into jetify-com:main with commit 2aca099 Mar 18, 2024
3 of 6 checks passed
nieomylnieja referenced this pull request in nieomylnieja/go-libyear May 18, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[jetpack-io/devbox-install-action](https://github.com/jetpack-io/devbox-install-action)
| action | minor | `v0.8.0` -> `v0.11.0` |

---

### Release Notes

<details>
<summary>jetpack-io/devbox-install-action
(jetpack-io/devbox-install-action)</summary>

###
[`v0.11.0`](https://github.com/jetify-com/devbox-install-action/releases/tag/v0.11.0)

[Compare
Source](https://github.com/jetpack-io/devbox-install-action/compare/v0.10.0...v0.11.0)

##### What's Changed

- \[macos] Fix latest macos by
[@&#8203;mikeland73](https://github.com/mikeland73) in
[https://github.com/jetify-com/devbox-install-action/pull/47](https://github.com/jetify-com/devbox-install-action/pull/47)

**Full Changelog**:
jetify-com/devbox-install-action@v0.10.0...v0.11.0

###
[`v0.10.0`](https://github.com/jetify-com/devbox-install-action/releases/tag/v0.10.0)

[Compare
Source](https://github.com/jetpack-io/devbox-install-action/compare/v0.9.0...v0.10.0)

##### What's Changed

- rebrand changes by [@&#8203;mohsenari](https://github.com/mohsenari)
in
[https://github.com/jetify-com/devbox-install-action/pull/42](https://github.com/jetify-com/devbox-install-action/pull/42)
- Update README with more up-to-date versions by
[@&#8203;loreto](https://github.com/loreto) in
[https://github.com/jetify-com/devbox-install-action/pull/44](https://github.com/jetify-com/devbox-install-action/pull/44)
- \[detsys] Bump detsys installer by
[@&#8203;mikeland73](https://github.com/mikeland73) in
[https://github.com/jetify-com/devbox-install-action/pull/46](https://github.com/jetify-com/devbox-install-action/pull/46)

##### New Contributors

- [@&#8203;mohsenari](https://github.com/mohsenari) made their first
contribution in
[https://github.com/jetify-com/devbox-install-action/pull/42](https://github.com/jetify-com/devbox-install-action/pull/42)
- [@&#8203;loreto](https://github.com/loreto) made their first
contribution in
[https://github.com/jetify-com/devbox-install-action/pull/44](https://github.com/jetify-com/devbox-install-action/pull/44)

**Full Changelog**:
jetify-com/devbox-install-action@v0.9.0...v0.10.0

###
[`v0.9.0`](https://github.com/jetify-com/devbox-install-action/releases/tag/v0.9.0)

[Compare
Source](https://github.com/jetpack-io/devbox-install-action/compare/v0.8.0...v0.9.0)

Re-release the Devbox GitHub Action under the new company name
(jetify-com instead of jetpack-io)

##### What's Changed

- Pin DeterminateSystems/nix-installer-action to SHA by
[@&#8203;wadells](https://github.com/wadells) in
[https://github.com/jetify-com/devbox-install-action/pull/32](https://github.com/jetify-com/devbox-install-action/pull/32)
- Add Dependabot config for GitHub Actions by
[@&#8203;wadells](https://github.com/wadells) in
[https://github.com/jetify-com/devbox-install-action/pull/31](https://github.com/jetify-com/devbox-install-action/pull/31)
- Bump actions/checkout from 3 to 4 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/jetify-com/devbox-install-action/pull/33](https://github.com/jetify-com/devbox-install-action/pull/33)
- Bump DeterminateSystems/nix-installer-action from 4 to 9 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/jetify-com/devbox-install-action/pull/34](https://github.com/jetify-com/devbox-install-action/pull/34)
- upgrade devbox cli test to use version 0.9.1 by
[@&#8203;LucilleH](https://github.com/LucilleH) in
[https://github.com/jetify-com/devbox-install-action/pull/37](https://github.com/jetify-com/devbox-install-action/pull/37)
- fix: use architecture as part of cache key by
[@&#8203;abbudao](https://github.com/abbudao) in
[https://github.com/jetify-com/devbox-install-action/pull/36](https://github.com/jetify-com/devbox-install-action/pull/36)

##### New Contributors

- [@&#8203;wadells](https://github.com/wadells) made their first
contribution in
[https://github.com/jetify-com/devbox-install-action/pull/32](https://github.com/jetify-com/devbox-install-action/pull/32)
- [@&#8203;dependabot](https://github.com/dependabot) made their first
contribution in
[https://github.com/jetify-com/devbox-install-action/pull/33](https://github.com/jetify-com/devbox-install-action/pull/33)
- [@&#8203;abbudao](https://github.com/abbudao) made their first
contribution in
[https://github.com/jetify-com/devbox-install-action/pull/36](https://github.com/jetify-com/devbox-install-action/pull/36)

**Full Changelog**:
jetify-com/devbox-install-action@v0.8.0...v0.9.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 10pm every weekday,before 5am
every weekday,every weekend" (UTC), Automerge - At any time (no schedule
defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/nieomylnieja/go-libyear).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjM2My41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Cache key should also include architecture
2 participants