Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add Zig implementation to README #74

Merged
merged 2 commits into from
Jul 5, 2023
Merged

Add Zig implementation to README #74

merged 2 commits into from
Jul 5, 2023

Conversation

tensorush
Copy link
Contributor

I've implemented TypeID in Zig and successfully tested it against the provided test data.

tensorush added 2 commits July 5, 2023 23:45
Signed-off-by: Jora Troosh <tensorush@gmail.com>
Add Zig implementation to README
@loreto
Copy link
Contributor

loreto commented Jul 5, 2023

@tensorush Thanks for contributing!

Take a look at #75 since we're planning to add two more test cases (one in the valid file and one in the invalid file) to catch 128-bit overflows. You can go ahead and add those to your implementation.

Copy link
Contributor

@loreto loreto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loreto loreto merged commit 6debefc into jetify-com:main Jul 5, 2023
@tensorush
Copy link
Contributor Author

@loreto Cool, I've added those tests as well.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants