[typeid] Enforce that the first suffix character is in the 0-7 range #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 5, 2023
akhundMurad
approved these changes
Jul 6, 2023
broothie
reviewed
Jul 6, 2023
| - name: suffix-overflow | ||
| # This is the first suffix that overflows into 129 bits | ||
| typeid: "prefix_8zzzzzzzzzzzzzzzzzzzzzzzzz" | ||
| description: "The should encode at most 128-bits" |
There was a problem hiding this comment.
Suggested change
| description: "The should encode at most 128-bits" | |
| description: "The suffix should encode at most 128-bits" |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change spec and implementations to enforce that the first suffix character should be in the
0-7range. This is because26 characters in base32 encode 130-bits, but UUIDs are only 128-bits. In order to guarantee that there are no
overflow errors and that the
typeid <-> uuidmapping is a bijective function, the maximum possible suffix is7zzzzzzzzzzzzzzzzzzzzzzzzz.This was first reported by @fxlae in jetify-com/typeid#20
This PR:
goandtypescriptimplementations