Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Group Domain Names Using Public Suffix List #153

Closed
null93 opened this issue Jul 14, 2021 · 0 comments
Closed

Group Domain Names Using Public Suffix List #153

null93 opened this issue Jul 14, 2021 · 0 comments
Assignees
Labels
bug Something is not working as expected effort: medium Will take a bit of effort to complete

Comments

@null93
Copy link
Contributor

null93 commented Jul 14, 2021

Instead of hacking together a regexp to group by effective TLDs, actually reference the https://publicsuffix.org/list/public_suffix_list.dat list and group the domains properly.

@null93 null93 self-assigned this Jul 14, 2021
@null93 null93 added effort: low Will take little effort to complete enhancement New feature or request bug Something is not working as expected effort: medium Will take a bit of effort to complete and removed enhancement New feature or request effort: low Will take little effort to complete labels Jul 14, 2021
null93 pushed a commit that referenced this issue Jul 15, 2021
@null93 null93 closed this as completed in 256e4d1 Jul 15, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something is not working as expected effort: medium Will take a bit of effort to complete
Projects
None yet
Development

No branches or pull requests

1 participant