Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Improve jetty-ssl-context.xml #3377

Closed
sbordet opened this issue Feb 21, 2019 · 5 comments · Fixed by #12592
Closed

Improve jetty-ssl-context.xml #3377

sbordet opened this issue Feb 21, 2019 · 5 comments · Fixed by #12592
Assignees
@sbordet

Comments

@sbordet
Copy link
Contributor

sbordet commented Feb 21, 2019

Currently jetty-ssl-context.xml defines only a subset of all the properties that are defined in SslContextFactory.
In particular, these are missing: [in|ex]cludeProtocols, [in|ex]cludeCipherSuites, possibly others.
We need to verify that we can pass a single CSV string and that is correctly parsed by SslContextFactory.
@stale
Copy link

stale bot commented Feb 21, 2020

This issue has been automatically marked as stale because it has been a full year without activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale For auto-closed stale issues and pull requests label Feb 21, 2020
@sbordet sbordet removed the Stale For auto-closed stale issues and pull requests label Feb 24, 2020
@stale
Copy link

stale bot commented Jun 9, 2021

This issue has been automatically marked as stale because it has been a full year without activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale For auto-closed stale issues and pull requests label Jun 9, 2021
@sbordet sbordet removed the Stale For auto-closed stale issues and pull requests label Jun 10, 2021
@github-actions
Copy link

This issue has been automatically marked as stale because it has been a
full year without activity. It will be closed if no further activity occurs.
Thank you for your contributions.

@github-actions github-actions bot added the Stale For auto-closed stale issues and pull requests label Jun 12, 2022
@sbordet sbordet removed the Stale For auto-closed stale issues and pull requests label Jun 13, 2022
@github-actions
Copy link

This issue has been automatically marked as stale because it has been a
full year without activity. It will be closed if no further activity occurs.
Thank you for your contributions.

@github-actions github-actions bot added the Stale For auto-closed stale issues and pull requests label Jun 15, 2023
@sbordet sbordet added Help Wanted and removed Stale For auto-closed stale issues and pull requests labels Jun 16, 2023
@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale because it has been a
full year without activity. It will be closed if no further activity occurs.
Thank you for your contributions.

@github-actions github-actions bot added the Stale For auto-closed stale issues and pull requests label Jun 16, 2024
@sbordet sbordet removed the Stale For auto-closed stale issues and pull requests label Jun 16, 2024
@sbordet sbordet self-assigned this Jun 16, 2024
sbordet added a commit that referenced this issue Nov 27, 2024
@sbordet
Fixes #3377 - Improve jetty-ssl-context.xml.
b62c774 
Split `ssl.mod` and `jetty-ssl.xml` into `ssl-context.mod` and `jetty-ssl-context.xml`.

Added as properties all those that were missing to configure `SslContextFactory`.

Updated documentation.
Removed duplicate documentation section about custom configuration of TLS properties via a custom XML file.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
@sbordet sbordet moved this to 🏗 In progress in Jetty 12.1.0 Nov 27, 2024
@sbordet sbordet linked a pull request Nov 27, 2024 that will close this issue
Fixes #3377 - Improve jetty-ssl-context.xml. #12592
Merged
sbordet added a commit that referenced this issue Nov 29, 2024
@sbordet
Fixes #3377 - Improve jetty-ssl-context.xml.
f4029ad 
Split `ssl.mod` and `jetty-ssl.xml` into `ssl-context.mod` and `jetty-ssl-context.xml`.

Added as properties all those that were missing to configure `SslContextFactory`.

Updated documentation.
Removed duplicate documentation section about custom configuration of TLS properties via a custom XML file.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
sbordet added a commit that referenced this issue Nov 29, 2024
@sbordet
Fixes #3377 - Improve jetty-ssl-context.xml. (#12592)
2e5e47d 
Split `ssl.mod` and `jetty-ssl.xml` into `ssl-context.mod` and `jetty-ssl-context.xml`.

Fixed module dependencies that previously depended on `ssl`, now depends on `ssl-context`.

Added as properties all those that were missing to configure `SslContextFactory`.

Updated documentation.
Removed duplicate documentation section about custom configuration of TLS properties via a custom XML file.

Renamed `conscrypt.xml` to `jetty-conscrypt.xml` as per convention.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
@sbordet sbordet closed this as completed Nov 29, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Jetty 12.1.0 Nov 29, 2024
@olamy olamy mentioned this issue Jan 31, 2025
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@sbordet sbordet

Labels
None yet
Projects
Jetty 12.1.0
Status: ✅ Done
Milestone
No milestone
1 participant
@sbordet