Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

duplicated classes between jetty and javax websocket implementations #4548

Closed
lachlan-roberts opened this issue Feb 6, 2020 · 0 comments · Fixed by #4549
Closed

duplicated classes between jetty and javax websocket implementations #4548

lachlan-roberts opened this issue Feb 6, 2020 · 0 comments · Fixed by #4549
Assignees

Comments

@lachlan-roberts
Copy link
Contributor

Jetty version
10.0.x

Description
The jetty and javax websocket implementation modules, specifically websocket-jetty-common and websocket-javax-common have many duplicated classes. By introducing a common module such as websocket-common or websocket-util, this duplication could be eliminated and this would make the code easier to update and maintain in the future.

@lachlan-roberts lachlan-roberts self-assigned this Feb 6, 2020
lachlan-roberts added a commit that referenced this issue Feb 18, 2020
…es (#4549)

Create new module websocket-util which contains implementation classes shared by websocket-jetty and websocket-javax. Many of these classes had to be changed as the javax and jetty versions of them differed slightly.

Also includes general cleanups, removed unused interfaces and classes, etc..
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant