Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Review RoundRobinConnectionPool #5217

Closed
sbordet opened this issue Sep 1, 2020 · 2 comments · Fixed by #5219 or #5218
Closed

Review RoundRobinConnectionPool #5217

sbordet opened this issue Sep 1, 2020 · 2 comments · Fixed by #5219 or #5218
Assignees
@sbordet

Comments

@sbordet
Copy link
Contributor

sbordet commented Sep 1, 2020

Jetty version
9.4.x

Description
With the work of #4975 and #5147 RoundRobinConnectionPool has received some attention, but could be improved.

Add javadocs and describe the peculiar behavior of round robin in detail.
Make tests less likely to fail.
@sbordet sbordet self-assigned this Sep 1, 2020
sbordet added a commit that referenced this issue Sep 1, 2020
@sbordet
Fixes #5217 - Review RoundRobinConnectionPool
f1a821f 
Introduced IndexedConnectionPool and RandomConnectionPool.
Clarified semantic of RoundRobinConnectionPool.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
@sbordet sbordet linked a pull request Sep 1, 2020 that will close this issue
Fixes #5217 - Review RoundRobinConnectionPool #5219
Merged
@gregw gregw mentioned this issue Sep 1, 2020
Merged
@gregw gregw linked a pull request Sep 1, 2020 that will close this issue
Alternative Pool Strategies #5218
Merged
sbordet added a commit that referenced this issue Sep 1, 2020
@sbordet
Fixes #5217 - Review RoundRobinConnectionPool
d20cea6 
Updates after review.
Fixed broken tests.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
@sbordet sbordet closed this as completed in 01135e1 Sep 9, 2020
@gregw
Copy link
Contributor

gregw commented Sep 15, 2020

Repoen for #5218

@gregw gregw reopened this Sep 15, 2020
@joakime
Copy link
Contributor

joakime commented Sep 17, 2020

PR #5218 merged.

@joakime joakime closed this as completed Sep 17, 2020
@sbordet sbordet mentioned this issue Jan 5, 2021
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@sbordet sbordet

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@gregw @joakime @sbordet