-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Standardize Path resolution in XmlConfiguration #6021
Comments
joakime
added a commit
that referenced
this issue
Mar 2, 2021
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime
added a commit
that referenced
this issue
Mar 2, 2021
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime
added a commit
that referenced
this issue
Mar 3, 2021
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime
added a commit
that referenced
this issue
Mar 3, 2021
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime
added a commit
that referenced
this issue
Mar 3, 2021
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime
added a commit
that referenced
this issue
Mar 3, 2021
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime
added a commit
that referenced
this issue
Mar 3, 2021
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime
added a commit
that referenced
this issue
Mar 3, 2021
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime
added a commit
that referenced
this issue
Mar 3, 2021
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime
added a commit
that referenced
this issue
Mar 3, 2021
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime
added a commit
that referenced
this issue
Mar 3, 2021
…solution Issue #6021 - PoC for resolvePath within XmlConfiguration
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Jetty version
10.0.0
Java version
All
OS type/version
All
Description
Currently, due to the way we use
<Set name="otherPath"><Property name="jetty.base" default="."/>/<Property name="jetty.other.path"/></Set>
it's complicating how we can support arbitrary paths for thejetty.other.path
property.The introduction of new properties for absolute path and deep nesting to allow overrides/defaults/replacements is needlessly complicating the XML.
If we just used
Path(base).resolve(configPath)
we get support for all things (absolute, relative, windows, linux, server shares, etc. pretty much anything that Java and it's FileSystem can support, we can then support).The text was updated successfully, but these errors were encountered: