Some ArrayTrie methods throw StackOverflowError when cointaining a very large entry

[lorban]

Jetty version(s)
9.4.x

Description
keySet() and toString() recurse too deep on large entries, so they're likely to throw StackOverflowError.

Consider the following:

Trie<String> trie = new ArrayTrie<>(Character.MAX_VALUE - 1);

char[] c1 = new char[Character.MAX_VALUE - 1];
Arrays.fill(c1, 'a');
String huge = new String(c1);
assertTrue(trie.put(huge, "wow"));
assertThat(trie.get(huge), is("wow"));

assertThat(trie.keySet(), notNullValue());   // <--- throws StackOverflowError
assertThat(trie.toString(), notNullValue()); // <--- throws StackOverflowError

[joakime]

@lorban is this done/complete now?

[lorban]

@joakime yes, it's all done and merged across the necessary branches. Thanks for the heads up.

[gregw]

@lorban did these changes make it into the jetty-12 branch? I think we need a process to track such issues?

[lorban]

@gregw no, they did not get merged to 12.0.x and you're right that we're going to need a process to remind us that.

I'm going to merge that right away.

[lorban]

Merged to 12.0.x.