Review naming of FrameHandler.isDemanding() in Jetty 12 #8991
Labels
Comments
|
Kind of agree the name (out at least the sense of the boolean) is messed up (yes it was my name). Something like |
lachlan-roberts
added a commit
that referenced
this issue
Feb 8, 2023
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts
added a commit
that referenced
this issue
Feb 9, 2023
…nding Issue #8991 - rename websocket isDemanding() method to isAutoDemanding()
gregpoulos
pushed a commit
to gregpoulos/jetty.project
that referenced
this issue
Feb 9, 2023
…x-documentation-operations-logging * upstream/jetty-12.0.x: (35 commits) Fixes jetty#9326 - Rename DecryptedEndPoint to SslEndPoint. Jetty 10 Upgrade to Hazelcast 5 and totally disable auto join multicast etc.. (fix build on CI) (jetty#9331) jetty#9328 - changes from review jetty#9287 - catch error in ee9 maxRequestSize MultiPart test Jetty 12.0.x 9301 fix ee10 jstl jpms (jetty#9321) Issue jetty#9301 Fix dependencies for ee10-glassfish-jstl module (jetty#9303) Jetty 12 Hazelcast 5.x and disable auto detection/multicast" (jetty#9332) jetty#9287 - fix further test failures Fixed imports. Issue jetty#7650 - Fix race condition when stopping QueuedThreadPool (jetty#9325) jetty#9287 - remove unpaired release of Content.Chunk Issue jetty#8991 - rename websocket isDemanding() method to isAutoDemanding() Issue jetty#9287 - fix failing tests changes f rom review add todo to revert to normal pool after fix for jetty#9311 Issue jetty#9309 - Introducing test for requestlog format with spaces use non-pooling RetainableByteBufferPool to work around performance bug consumeAvailable should use number of reads instead of bytes fix for retainable merge changes from review ...
|
Fixed by #9328. |
github-project-automation
bot
moved this from To Do
to ✅ Done
in Jetty 12.0.0.beta0 - FROZEN
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Currently
FrameHandlerhas a method calledisDemanding()which specifies whether aFrameHandlerwill have to manage its own flow control by using theCoreSession.demand()method.demanding == falsemeans that demand is combined with the callback.demanding == truemeans that frame handler must usedemand()method.Simone says this is confusing and this should be renamed in Jetty 12.
see #8487 (comment)
The text was updated successfully, but these errors were encountered: