Issue #11579 - Reject Target in Request Path #11580
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joakime
added
Enhancement
Specification
|
@joakime status? |
|
I haven't look at this in a while, since we moved it here from PR #11496 |
gregw
requested changes
Jun 20, 2024
|
rebase against 12.1.x |
gregw
requested changes
Nov 8, 2024
Comment on lines
+1460
to
+1462
| if (last != null && state.ordinal() > last.ordinal()) | ||
| throw new IllegalArgumentException("uri cannot go beyond " + last); | ||
|
|
There was a problem hiding this comment.
I don't think we should not parse past the fragment etc. We should parse to the end, but record a violation if there is a fragment.
|
Closing in favor of PR #12504 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation of rejecting a URI Target in the Request Path.