Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fixes #12436 - Allow headers size extend to maxRequestHeadersSize in http client. #12544

Merged
merged 2 commits into from
Nov 17, 2024
Merged

Fixes #12436 - Allow headers size extend to maxRequestHeadersSize in http client. #12544

merged 2 commits into from
Nov 17, 2024

Conversation

sbordet
Copy link
Contributor

@sbordet sbordet commented Nov 15, 2024

Initially contributed by @shaoxt, but reworked in light of #12351.

For HTTP/1, headers are initially generated using HttpClient.getRequestBufferSize().
If that overflows, headers are generated again with HttpClient.getMaxRequestHeadersSize().
This allows most of the requests to use a smaller buffer.

shaoxt and others added 2 commits November 15, 2024 23:31
@shaoxt @sbordet
Issue #12436 - Allow headers size extend to maxRequestHeadersSize in …
294f33b 
…http client.
@sbordet
Fixes #12436 - Allow headers size extend to maxRequestHeadersSize in …
042e2a3 
…http client.

Reworked contribution by @shaoxt in light of the work done in #12351.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
@sbordet sbordet requested review from lorban and gregw November 15, 2024 23:11
@sbordet sbordet mentioned this pull request Nov 15, 2024
Closed
@sbordet sbordet linked an issue Nov 15, 2024 that may be closed by this pull request
Allow headers size extend to maxRequestHeadersSize in http client #12436
Closed
@shaoxt
Copy link
Contributor

shaoxt commented Nov 15, 2024

Thanks a lot to make this PR green.

@sbordet sbordet merged commit 72e9933 into jetty-12.1.x Nov 17, 2024
10 checks passed
@sbordet sbordet deleted the fix/jetty-12.1.x/shaoxt-max-request-headers-size branch November 17, 2024 23:42
@shaoxt
Copy link
Contributor

shaoxt commented Nov 18, 2024

Thanks a lot to modify and merge this PR.
Will the changes be carry over to Jetty 11 ?

@sbordet
Copy link
Contributor Author

sbordet commented Nov 18, 2024

@shaoxt no, they will not be backported to Jetty 11, as Jetty 11 is at end of community support:

If you need this feature backported to Jetty 11, you can contact Webtide for commercial support.

@sbordet sbordet mentioned this pull request Jan 4, 2025
Closed
sbordet added a commit that referenced this pull request Feb 6, 2025
@sbordet
Fixes #12670 - Improve buffer management of HTTP/1 response headers.
0345420 
* Backported #12544 (client-side handling of request header overflow).
* Introduced HttpConfiguration.maxResponseHeaderSize
* Implemented server-side handling of response header overflow, similar to the client.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
@sbordet sbordet mentioned this pull request Feb 6, 2025
Merged
sbordet added a commit that referenced this pull request Feb 7, 2025
@sbordet
Fixes #12670 - Improve buffer management of HTTP/1 response headers. (#…
bce7153 
…12777)

* Backported #12544 (client-side handling of request header overflow).
* Introduced HttpConfiguration.maxResponseHeaderSize
* Implemented server-side handling of response header overflow, similar to the client.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@gregw gregw gregw approved these changes

@lorban lorban Awaiting requested review from lorban

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow headers size extend to maxRequestHeadersSize in http client
3 participants
@sbordet @shaoxt @gregw